-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make cacert export save only CA certificates #859
Conversation
Rebased |
yarn.lock
Outdated
@@ -294,7 +294,6 @@ | |||
"@kubernetes/client-node@0.11.2": | |||
version "0.11.2" | |||
resolved "https://registry.yarnpkg.com/@kubernetes/client-node/-/client-node-0.11.2.tgz#5dbc1d66d3c954af0f3bd294dece884737f5b761" | |||
integrity sha512-Uhwd2y2qCvugICnHRC5h2MT5vw0a1dJPVVltVwmkeMuyGTPBccsTtpTcSfSLitwOrh4yr+9wG5bRcMdgeRjYPw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why but we have a lot of removed lines like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I just use yarn as usual.... Will revert these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see, yarn deletes them automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integrity sha512-Uhwd2y2qCvugICnHRC5h2MT5vw0a1dJPVVltVwmkeMuyGTPBccsTtpTcSfSLitwOrh4yr+9wG5bRcMdgeRjYPw==
This thing generation depends on yarn version
/test v5-chectl-e2e |
/retest |
hello, which version of yarn do you have ? |
for (const certPem of certsPem) { | ||
const cert = nodeforge.pki.certificateFromPem(certPem) | ||
const basicConstraintsExt = cert.getExtension('basicConstraints') | ||
if (basicConstraintsExt && (basicConstraintsExt as any).cA) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cA
is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Otherwise it wouldn't work. (I also wondered why they named the field such way).
@benoitf I have 1.6.0 which I must update. |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Fixes
cacert:export
command to save only CA certificate from the certificate chain of theself-signed-certificate
secret.What issues does this PR fix or reference?
eclipse-che/che#16773